Add TimmBackbone model #22619
Merged
Add TimmBackbone model #22619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
amyeroberts
force-pushed
the
add-timm-backbone-model
branch
2 times, most recently
from
37cd88d to
345672d
Compare
amyeroberts
commented
May 11, 2023
| @@ -445,6 +445,7 @@ def job_name(self): | |||
| "pip install -e .[dev]", | |||
| "pip install git+https://github.com/huggingface/accelerate", | |||
| "pip install --upgrade pytest pytest-sugar", | |||
| "pip install natten", | |||
There was a problem hiding this comment.
Needed for Dinat and Nat doc tests
sgugger
approved these changes
May 11, 2023
|
|
||
| def __init__(self, config, **kwargs): | ||
| requires_backends(self, "timm") | ||
| import timm |
There was a problem hiding this comment.
Might be cleaner to do this at the top of the file under an is_timm_available() but no strong opinions.
amyeroberts
force-pushed
the
add-timm-backbone-model
branch
from
0745535 to
8316f23
Compare
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
|
@ydshieh Merging now. I'll address any comments or requests for changes in a follow up PR. |
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* Add test_backbone for convnext * Add TimmBackbone model * Add check for backbone type * Tidying up - config checks * Update convnextv2 * Tidy up * Fix indices & clearer comment * Exceptions for config checks * Correclty update config for tests * Safer imports * Safer safer imports * Fix where decorators go * Update import logic and backbone tests * More import fixes * Fixup * Only import all_models if torch available * Fix kwarg updates in from_pretrained & main rebase * Tidy up * Add tests for AutoBackbone * Tidy up * Fix import error * Fix up * Install nattan in doc_test_job * Revert back to setting self._out_xxx directly * Bug fix - out_indices mapping from out_features * Fix tests * Dont accept output_loading_info for Timm models * Set out_xxx and don't remap * Use smaller checkpoint for test * Don't remap timm indices - check out_indices based on stage names * Skip test as it's n/a * Apply suggestions from code review Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Cleaner imports / spelling is hard --------- Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new model TimmBackbone to use for loading timm weights for use in the AutoBackbone API.
Example usage:
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.