Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Past CI not running against the latest main #22823

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Fix Past CI not running against the latest main #22823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/self-nightly-past-ci-caller.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
with:
framework: pytorch
version: "1.13"
sha: ${{ github.sha }}
Copy link
Collaborator Author

@ydshieh ydshieh Apr 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow file self-past.yml, when used in a workflow_call, accept some inputs including sha:

transformers/.github/workflows/self-past.yml

Lines 10 to 22 in 0670ccb

workflow_call:
inputs:
framework:
required: true
type: string
version:
required: true
type: string
# Use this to control the commit to test against
sha:
default: 'main'
required: false
type: string

Previously, the Past CI is launched manually by @ydshieh, and the goal is to targe a fixed & specific commit for some runs (so we can compare the results before/after the fixes). At that time, it was launched only once during a few months.

Right now, we run it twice per week, see #22393, it makes more sense to run the CI against latest main. Otherwise, the reports of the (automatically triggered) runs will contain failures that have been fixed on main and hard to understand at the 1st galance.

secrets: inherit

run_past_ci_pytorch_1-12:
Expand All @@ -40,6 +41,7 @@ jobs:
with:
framework: pytorch
version: "1.12"
sha: ${{ github.sha }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass the commit sha of the triggered event to past workflow file.

secrets: inherit

run_past_ci_pytorch_1-11:
Expand All @@ -50,6 +52,7 @@ jobs:
with:
framework: pytorch
version: "1.11"
sha: ${{ github.sha }}
secrets: inherit

run_past_ci_pytorch_1-10:
Expand All @@ -60,6 +63,7 @@ jobs:
with:
framework: pytorch
version: "1.10"
sha: ${{ github.sha }}
secrets: inherit

run_past_ci_pytorch_1-9:
Expand All @@ -70,6 +74,7 @@ jobs:
with:
framework: pytorch
version: "1.9"
sha: ${{ github.sha }}
secrets: inherit

run_past_ci_tensorflow_2-11:
Expand All @@ -80,6 +85,7 @@ jobs:
with:
framework: tensorflow
version: "2.11"
sha: ${{ github.sha }}
secrets: inherit

run_past_ci_tensorflow_2-10:
Expand All @@ -90,6 +96,7 @@ jobs:
with:
framework: tensorflow
version: "2.10"
sha: ${{ github.sha }}
secrets: inherit

run_past_ci_tensorflow_2-9:
Expand All @@ -100,6 +107,7 @@ jobs:
with:
framework: tensorflow
version: "2.9"
sha: ${{ github.sha }}
secrets: inherit

run_past_ci_tensorflow_2-8:
Expand All @@ -110,6 +118,7 @@ jobs:
with:
framework: tensorflow
version: "2.8"
sha: ${{ github.sha }}
secrets: inherit

run_past_ci_tensorflow_2-7:
Expand All @@ -120,6 +129,7 @@ jobs:
with:
framework: tensorflow
version: "2.7"
sha: ${{ github.sha }}
secrets: inherit

run_past_ci_tensorflow_2-6:
Expand All @@ -130,6 +140,7 @@ jobs:
with:
framework: tensorflow
version: "2.6"
sha: ${{ github.sha }}
secrets: inherit

run_past_ci_tensorflow_2-5:
Expand All @@ -140,4 +151,5 @@ jobs:
with:
framework: tensorflow
version: "2.5"
sha: ${{ github.sha }}
secrets: inherit