-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert DeepSpeed stuff #22899
Revert DeepSpeed stuff #22899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me sad, but if you really need to...
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
I see this was included in transformers 4.29.0 (https://github.com/huggingface/transformers/releases/tag/v4.29.0). Could you share more about how this changes the Transformers + DeepSpeed integration? I don't quite understand the diff. Does this disable some deeper level of integration of DS with Transformers? |
@jli this pr just reverted a small portion of Accelerate handling the deepspeed part when we weren't ready for that yet. CC @pacman100 if you could explain accelerates deepspeed integration vs the transformers one were replacing in terms of features? :) |
What does this PR do?
During the integration some deepspeed items that need further looks into before it can be part of the integration need to be addressed/looked at more carefully. This PR reverts the base deepspeed logic done in
setup_devices
andparallel_mode
to restore the original deepspeed behaviorFixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sgugger, cc @pacman100 so you're aware.