Fix a minor bug in CI slack report #22906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Apr 21, 2023
| artifact_zip_path = os.path.join(output_dir, f"{artifact_name}.zip") | ||
| if os.path.isfile(artifact_zip_path): | ||
| results[artifact_name] = {} |
There was a problem hiding this comment.
add the key only if the artifact is downloaded
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
requested review from
amyeroberts and
sgugger
and removed request for
amyeroberts
amyeroberts
approved these changes
Apr 21, 2023
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#22798 added code to show the difference between 2 CI runs. However, the previous CI run(s) may not yet produced the artifact
test_failure_tables, and we gotKeyError: 'model_failures_report.txt'in the last run.This PR adds some check.