Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated tasks/image_captioning.mdx to Korean #22943

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

sim-so
Copy link
Contributor

@sim-so sim-so commented Apr 23, 2023

What does this PR do?

Translated the tasks/image_captioning.mdx file of the documentation to Korean.
Thank you in advance for your review!

  • 이미지 캡셔닝 Image captioning
    • 포켓몬 BLIP 데이터셋 가져오기 Load the Pokémon BLIP captions dataset
    • 데이터셋 전처리 Preprocess the dataset
    • 기본 모델 가져오기 Load a base model
    • 평가 Evaluate
    • 학습! Train!
    • 추론 Inference

Part of #20179

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

This is a work on progress.
Could you review this PR when I finish this work?
@0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 23, 2023

The documentation is not available anymore as the PR was closed or merged.

@sim-so
Copy link
Contributor Author

sim-so commented Apr 23, 2023

I quickly done it! 😅
Would you review this PR?

@sim-so sim-so force-pushed the ko-image-captioning branch from b54d423 to 947f5e5 Compare April 24, 2023 03:42
Copy link
Contributor

@0525hhgus 0525hhgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다 😄 문법까지 모두 완벽하네요..!
전 다른 피드백 없습니다 👍 하단에 리뷰 남겼습니다!

Copy link
Contributor

@0525hhgus 0525hhgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가로 리뷰드립니다!

docs/source/ko/_toctree.yml Outdated Show resolved Hide resolved
docs/source/ko/tasks/image_captioning.mdx Outdated Show resolved Hide resolved
Co-Authored-By: Hyeonseo Yun <0525_hhgus@naver.com>
Co-Authored-By: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-Authored-By: Wonhyeong Seo <wonhseo@kakao.com>
Co-Authored-By: Gabriel Yang <gabrielwithhappy@gmail.com>
Co-Authored-By: Nayeon Han <nayeon2.han@gmail.com>
Co-Authored-By: Kihoon Son <75935546+kihoon71@users.noreply.github.com>
Co-Authored-By: Hyeonseo Yun <0525yhs@gmail.com>
@sim-so sim-so force-pushed the ko-image-captioning branch from 851edc2 to 099345c Compare April 24, 2023 13:59
Copy link
Contributor

@wonhyeongseo wonhyeongseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@gabrielwithappy
Copy link
Contributor

LGTM! 🤗

@sim-so sim-so marked this pull request as ready for review April 26, 2023 04:40
@sim-so
Copy link
Contributor Author

sim-so commented Apr 26, 2023

Happy Wednesday!
Could you review this PR? 😃
@sgugger, @ArthurZucker, @eunseojo

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@sgugger sgugger merged commit 6dc2474 into huggingface:main Apr 26, 2023
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
…gface#22943)

docs: ko: tasks/image_captioning.mdx

Co-authored-by: Hyeonseo Yun <0525_hhgus@naver.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
Co-authored-by: Gabriel Yang <gabrielwithhappy@gmail.com>
Co-authored-by: Nayeon Han <nayeon2.han@gmail.com>
Co-authored-by: Kihoon Son <75935546+kihoon71@users.noreply.github.com>
Co-authored-by: Hyeonseo Yun <0525yhs@gmail.com>
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
…gface#22943)

docs: ko: tasks/image_captioning.mdx

Co-authored-by: Hyeonseo Yun <0525_hhgus@naver.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
Co-authored-by: Gabriel Yang <gabrielwithhappy@gmail.com>
Co-authored-by: Nayeon Han <nayeon2.han@gmail.com>
Co-authored-by: Kihoon Son <75935546+kihoon71@users.noreply.github.com>
Co-authored-by: Hyeonseo Yun <0525yhs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants