Fix DeepSpeed CI job link in Past CI
#22967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Apr 24, 2023
| job_name = f"{key} ({artifact_path['gpu']}-gpu)" | ||
| if job_name_prefix: | ||
| job_name = f"{job_name_prefix} / {job_name}" | ||
| additional_results[key]["job_link"][artifact_path["gpu"]] = github_actions_job_links.get(job_name) |
There was a problem hiding this comment.
For model test jobs in Past CI, we have
transformers/utils/notification_service.py
Lines 906 to 909 in 741035f
PyTorch 1.13 / Model tests (models/audio_spectrogram_transformer, multi-gpu)
In #22393, we added DeepSpeed test job to Nightly/Past CI, but I forgot to apply the same change mentioned above to this additional test jobs (i.e. not model test job), and the job links are missing for them in the Slack report. The job name should look like
PyTorch 1.13 / Torch CUDA extension tests (single-gpu)
|
The documentation is not available anymore as the PR was closed or merged. |
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
* Fix job link * fix artifact name logic --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* Fix job link * fix artifact name logic --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix missing
DeepSpeedCI job link in Past CI. See comment in the change.