Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix None value when adding info to auto_map #22990

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix None value when adding info to auto_map #22990

merged 1 commit into from
Apr 26, 2023

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Apr 25, 2023

What does this PR do?

This should fix the issue encountered in #22983: before testing if -- in in a value of the auto map, we need to make sure it's not None.

Fixes #22983

@sgugger sgugger requested a review from ArthurZucker April 25, 2023 13:37
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 25, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is making me think we should have tests for custom model etc as we are pushing contributors there

@sgugger
Copy link
Collaborator Author

sgugger commented Apr 26, 2023

There are some, it's juss the case when there is only a fast tokenizer that is custom that is not tested.

@sgugger sgugger merged commit 4331923 into main Apr 26, 2023
@sgugger sgugger deleted the fix_auto_map_none branch April 26, 2023 18:39
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using auto_map in tokenizer_config.json gives TypeError: argument of type 'NoneType' is not iterable
3 participants