Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pix2Struct] Fix pix2struct doctest #23023

Merged

Conversation

younesbelkada
Copy link
Contributor

What does this PR do?

Fixes Pix2Struct doctest
Link to failing job: https://github.com/huggingface/transformers/actions/runs/4815336726/jobs/8573921590

With #23004 being merged, the label smoothing of the loss function has been removed. Therefore the expected value of the loss function changed, leading to the failing doctest.

cc @ydshieh

@younesbelkada younesbelkada requested a review from ydshieh April 27, 2023 09:14
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 27, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @younesbelkada ❤️‍🔥

@younesbelkada younesbelkada merged commit 9435cc6 into huggingface:main Apr 27, 2023
@younesbelkada younesbelkada deleted the fix-pix2struct-doctest branch April 27, 2023 09:48
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants