Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated tasks/zero_shot_image_classification.mdx to Korean #23065

Merged
merged 1 commit into from
May 2, 2023

Conversation

HanNayeoniee
Copy link
Contributor

@HanNayeoniee HanNayeoniee commented Apr 29, 2023

What does this PR do?

Translated the tasks/zero_shot_image_classification.mdx file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR? @0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@sgugger, @ArthurZucker, @eunseojo May you please review this PR?

@HanNayeoniee HanNayeoniee changed the title 🌐 [i18n-KO] Translated tasks/zero_shot_image_classification.mdx to Korean 🌐 [i18n-KO] Translated zero_shot_image_classification.mdx to Korean Apr 29, 2023
@HanNayeoniee HanNayeoniee changed the title 🌐 [i18n-KO] Translated zero_shot_image_classification.mdx to Korean 🌐 [i18n-KO] Translated tasks/zero_shot_image_classification.mdx to Korean Apr 29, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 29, 2023

The documentation is not available anymore as the PR was closed or merged.

@gabrielwithappy
Copy link
Contributor

LGTM! :-)

Copy link
Contributor

@0525hhgus 0525hhgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다! candidate_labels과 같이 코드를 고려하여 번역해주셔서 이해가 수월했습니다 👍
아래 짧은 리뷰 남깁니다 🙂

docs/source/ko/tasks/zero_shot_image_classification.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@sim-so sim-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 덕분에 금방 읽었어요 🙌
아래와 같이 짧은 리뷰를 덧붙입니다!

docs/source/ko/tasks/zero_shot_image_classification.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/zero_shot_image_classification.mdx Outdated Show resolved Hide resolved
Co-Authored-By: Hyeonseo Yun <0525_hhgus@naver.com>
Co-Authored-By: Gabriel Yang <gabrielwithhappy@gmail.com>
Co-Authored-By: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-Authored-By: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-Authored-By: Wonhyeong Seo <wonhseo@kakao.com>
@HanNayeoniee HanNayeoniee marked this pull request as ready for review May 1, 2023 23:39
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sgugger sgugger merged commit f9426ee into huggingface:main May 2, 2023
@HanNayeoniee HanNayeoniee deleted the ko-zero-shot-img branch May 2, 2023 15:10
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
…Korean (huggingface#23065)

docs: ko: `tasks/zero_shot_image_classification`

Co-authored-by: Hyeonseo Yun <0525_hhgus@naver.com>
Co-authored-by: Gabriel Yang <gabrielwithhappy@gmail.com>
Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
…Korean (huggingface#23065)

docs: ko: `tasks/zero_shot_image_classification`

Co-authored-by: Hyeonseo Yun <0525_hhgus@naver.com>
Co-authored-by: Gabriel Yang <gabrielwithhappy@gmail.com>
Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants