Support union types X | Y syntax for HfArgumentParser for Python 3.10+
#23126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
May 3, 2023
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
…3.10+ (huggingface#23126) * Support union types `X | Y` syntax for `HfArgumentParser` for Python 3.10+ * Add tests for PEP 604 for `HfArgumentParser` * Reorganize tests
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
…3.10+ (huggingface#23126) * Support union types `X | Y` syntax for `HfArgumentParser` for Python 3.10+ * Add tests for PEP 604 for `HfArgumentParser` * Reorganize tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support union types
X | Ysyntax forHfArgumentParserfor Python 3.10+. Allow users using Python 3.10+ to opt in new typing futures, such as union typesX | Y(PEP 604). Note thattyping.get_type_hintsdoes not work for union types on Python 3.7-3.9.Fixes #20249
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Testing union types
X | Yfor Python 3.7-3.9 needs to addfrom __future__ import annotationsat the top of the test script. I'm not sure should we need to create a separate test script or add new test cases directly intests/utils/test_hf_argparser.py.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.