-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only add files with modification outside doc blocks #23327
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -225,10 +225,23 @@ def get_diff_for_py_and_mdx_files(repo, base_commit, commits): | |||
for commit in commits: | ||||
for diff_obj in commit.diff(base_commit): | ||||
# We always add new python files | ||||
if diff_obj.change_type in ["A", "M", "R"] and ( | ||||
diff_obj.b_path.endswith(".py") or diff_obj.b_path.endswith(".mdx") | ||||
): | ||||
if diff_obj.change_type in ["A"] and (diff_obj.b_path.endswith(".py") or diff_obj.b_path.endswith(".mdx")): | ||||
code_diff.append(diff_obj.b_path) | ||||
# Now for modified files | ||||
elif ( | ||||
diff_obj.change_type in ["M", "R"] | ||||
and diff_obj.b_path.endswith(".py") | ||||
or diff_obj.b_path.endswith(".mdx") | ||||
): | ||||
# In case of renames, we'll look at the tests using both the old and new name. | ||||
if diff_obj.a_path != diff_obj.b_path: | ||||
code_diff.extend([diff_obj.a_path, diff_obj.b_path]) | ||||
else: | ||||
# Otherwise, we check modifications are in code and not docstrings. | ||||
if diff_is_docstring_only(repo, commit, diff_obj.b_path): | ||||
print(f"Ignoring diff in {diff_obj.b_path} as it only concerns docstrings or comments.") | ||||
else: | ||||
code_diff.append(diff_obj.a_path) | ||||
Comment on lines
+230
to
+244
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. copied from transformers/utils/tests_fetcher.py Line 165 in c2589a8
|
||||
|
||||
return code_diff | ||||
|
||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min. version to make the following work (used in
src/transformers/testing_utils.py
for the doctest in PRs)