Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoder-Decoder: add informative exception when the decoder is not compatible #23426

Merged
merged 1 commit into from
May 17, 2023

Conversation

gante
Copy link
Member

@gante gante commented May 17, 2023

What does this PR do?

Related to #23350

Many decoder models are not compatible with our EncoderDecoder structure (mostly because using the encoded hidden states appropriately requires extra code in the decoder model architecture itself). This PR adds an informative message in the presence of incompatible decoder models.

@gante gante changed the title add informative exception Encoder-Decoder: add informative exception May 17, 2023
@gante gante changed the title Encoder-Decoder: add informative exception Encoder-Decoder: add informative exception when the decoder is not compatible May 17, 2023
@gante gante requested a review from amyeroberts May 17, 2023 12:34
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 17, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@gante gante merged commit a574de3 into huggingface:main May 17, 2023
@gante gante deleted the encoder_decoder_exc branch May 17, 2023 16:42
sheonhan pushed a commit to sheonhan/transformers that referenced this pull request Jun 1, 2023
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants