Generate: skip left-padding tests on old models #23437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
commented
May 17, 2023
| @@ -1516,3 +1516,7 @@ def test_retain_grad_hidden_states_attentions(self): | |||
|
|
|||
| def test_save_load_fast_init_from_base(self): | |||
| pass | |||
|
|
|||
| @unittest.skip("The model doesn't support left padding") # and it's not used enough to be worth fixing :) | |||
There was a problem hiding this comment.
Note that this is not Bart, but the BartDecoder used as a stand-alone model. 11 out of the 16 skips below follow this pattern, a decoder used as a stand-alone model (which is not very used in practice, afaik).
The exceptions are CTRL, ImageGPT, Reformer, and TransfoXL
|
The documentation is not available anymore as the PR was closed or merged. |
|
It seems like |
ydshieh
approved these changes
May 18, 2023
|
@gante it all passes now 😄 |
sheonhan
pushed a commit
to sheonhan/transformers
that referenced
this pull request
Jun 1, 2023
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have a few left-padding tests polluting our daily CI -- these are from old models, where it is not worth committing >1hr per model to add support for left padding.
This PR skips the test in those models, so we can focus our energy where it matters :)