Less flaky test_assisted_decoding_matches_greedy_search
#23451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
May 18, 2023
| config, input_ids, attention_mask, max_length = self._get_input_ids_and_config(batch_size=1) | ||
| # This for loop is a naive and temporary effort to make the test less flaky. | ||
| failures = [] | ||
| for i in range(10): |
There was a problem hiding this comment.
with this for loop, each test's runtime increases by ~1 second
|
The documentation is not available anymore as the PR was closed or merged. |
gante
approved these changes
May 18, 2023
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
…e#23451) * fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
…e#23451) * fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Less flaky
test_assisted_decoding_matches_greedy_search: fail only if more than 1 failure among 10.