Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly guard PyTorch stuff #23452

Merged
merged 5 commits into from
May 18, 2023
Merged

Properly guard PyTorch stuff #23452

merged 5 commits into from
May 18, 2023

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented May 18, 2023

What does this PR do?

#23438 accidentally broke main since the objects in .generation imported are only available when PyTorch is installed. This PR fixes that.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 18, 2023

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger merged commit 167aa76 into main May 18, 2023
@sgugger sgugger deleted the fix_main branch May 18, 2023 16:17
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
* Properly guard PyTorch stuff

* [all-test]

* [all-test] Fix model imports as well

* Making sure StoppingCriteria is always defined

* [all-test]
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
* Properly guard PyTorch stuff

* [all-test]

* [all-test] Fix model imports as well

* Making sure StoppingCriteria is always defined

* [all-test]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants