Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TF ESM inv_freq non-trainable like PyTorch #23940

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

Rocketknight1
Copy link
Member

Minor TF-ESM fix - the inv_freq weight is a non-trainable buffer in PyTorch, but was trainable in TF models. This might cause small discrepancies when fine-tuning.

@Rocketknight1 Rocketknight1 requested a review from sgugger June 1, 2023 14:36
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 1, 2023

The documentation is not available anymore as the PR was closed or merged.

@Rocketknight1 Rocketknight1 merged commit 8088ca4 into main Jun 1, 2023
@Rocketknight1 Rocketknight1 deleted the esm_inv_freq_fix branch June 1, 2023 15:15
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants