Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated tasks_summary.mdx to Korean #23977

Merged
merged 6 commits into from
Jun 12, 2023

Conversation

kihoon71
Copy link
Contributor

@kihoon71 kihoon71 commented Jun 3, 2023

What does this PR do?

Translated task_summary.mdx file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR? @0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?(Final)

@sgugger, @ArthurZucker, @eunseojo May you please review this PR?

Co-Authored-By: Hyeonseo Yun <0525yhs@gmail.com>
Co-Authored-By: Wonhyeong Seo <wonhseo@kakao.com>
Co-Authored-By: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-Authored-By: Gabriel Yang <gabrielwithhappy@gmail.com>
Co-Authored-By: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-Authored-By: Nayeon Han <nayeon2.han@gmail.com>
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 3, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@sim-so sim-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

내용이 많은 문서를 읽기 쉽게 잘 번역해주신 것 같아요!
glossary에 관한 의견을 몇 가지 보내 드립니다.

docs/source/ko/task_summary.mdx Outdated Show resolved Hide resolved
docs/source/ko/task_summary.mdx Outdated Show resolved Hide resolved
docs/source/ko/task_summary.mdx Outdated Show resolved Hide resolved
docs/source/ko/task_summary.mdx Outdated Show resolved Hide resolved
docs/source/ko/task_summary.mdx Outdated Show resolved Hide resolved
docs/source/ko/task_summary.mdx Outdated Show resolved Hide resolved
docs/source/ko/task_summary.mdx Outdated Show resolved Hide resolved
docs/source/ko/task_summary.mdx Outdated Show resolved Hide resolved
docs/source/ko/task_summary.mdx Outdated Show resolved Hide resolved
docs/source/ko/task_summary.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@0525hhgus 0525hhgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다 👍
긴 글이었지만, 용어를 이해하기 쉽도록 번역해주셨군요!
아래 짧은 리뷰를 남깁니다!

docs/source/ko/task_summary.mdx Outdated Show resolved Hide resolved
docs/source/ko/task_summary.mdx Outdated Show resolved Hide resolved
docs/source/ko/task_summary.mdx Outdated Show resolved Hide resolved
docs/source/ko/task_summary.mdx Outdated Show resolved Hide resolved
docs/source/ko/task_summary.mdx Outdated Show resolved Hide resolved
kihoon71 and others added 5 commits June 12, 2023 22:40
@kihoon71 kihoon71 marked this pull request as ready for review June 12, 2023 15:02
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sgugger sgugger merged commit dc42a9d into huggingface:main Jun 12, 2023
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
* 🌐 [i18n-KO] Translated tasks_summary.mdx to Korean

Co-Authored-By: Hyeonseo Yun <0525yhs@gmail.com>
Co-Authored-By: Wonhyeong Seo <wonhseo@kakao.com>
Co-Authored-By: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-Authored-By: Gabriel Yang <gabrielwithhappy@gmail.com>
Co-Authored-By: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-Authored-By: Nayeon Han <nayeon2.han@gmail.com>

* Apply suggestions from code review

Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-authored-by: Hyeonseo Yun <0525yhs@gmail.com>

* Update _toctree.yml

* Delete generation_strategies.mdx

* Delete tasks_explained.mdx

---------

Co-authored-by: Hyeonseo Yun <0525yhs@gmail.com>
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-authored-by: Gabriel Yang <gabrielwithhappy@gmail.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Nayeon Han <nayeon2.han@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants