Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ZeroDivisionError on trainer.evaluate if model and dataset are tiny #24049

Merged

Conversation

tomaarsen
Copy link
Member

Closes #24048

Hello!

Pull Request overview

  • Prevent ZeroDivisionError on trainer.evaluate if model and dataset are tiny

Details

Please see #24048 for details.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Tests would be quite flaky for this.

Who can review?

@sgugger, @younesbelkada

  • Tom Aarsen

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks for the fix!

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks so much!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 6, 2023

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger merged commit 02fe3af into huggingface:main Jun 6, 2023
@tomaarsen tomaarsen deleted the fix/zero_div_error_speed_metrics branch June 6, 2023 16:04
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
…are tiny (huggingface#24049)

Prevent ZeroDivisionError if evaluation is too quick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZeroDivisionError on trainer.evaluate if model and dataset are tiny
4 participants