Fix device issue in OpenLlamaModelTest::test_model_parallelism
#24195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Jun 12, 2023
| @@ -736,12 +736,16 @@ def forward( | |||
|
|
|||
| hidden_states = outputs[0] | |||
| if self.config.shared_input_output_embedding: | |||
| logits = torch.einsum("blh,vh->blv", hidden_states, self.model.embed_tokens.weight) | |||
| logits = torch.einsum( | |||
| "blh,vh->blv", hidden_states.to(self.model.embed_tokens.weight.device), self.model.embed_tokens.weight | |||
There was a problem hiding this comment.
send hidden_states (lighter) to embedding's (heavy) device.
ydshieh
commented
Jun 12, 2023
| else: | ||
| logits = self.lm_head(hidden_states) | ||
|
|
||
| loss = None | ||
| if labels is not None: | ||
| # move labels to correct device to enable model parallelism | ||
| labels = labels.to(logits.device) |
There was a problem hiding this comment.
just copied from other modeling files.
|
The documentation is not available anymore as the PR was closed or merged. |
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
…gingface#24195) fix Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See the comments in the changes.
Currently, CI has a failure