Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update (TF)SamModelIntegrationTest #24199

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Update (TF)SamModelIntegrationTest #24199

merged 1 commit into from
Jun 13, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jun 12, 2023

What does this PR do?

  • Add require_tf: otherwise, past CI's torch job (with only torch installed) will fail for this test class
  • Add TF prefix: as usual convention

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 12, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@Rocketknight1
Copy link
Member

Good catch, and sorry! I'll tell GPT-4 to watch that one in future, lol

@ydshieh ydshieh merged commit 74b846c into main Jun 13, 2023
@ydshieh ydshieh deleted the better_tf_sam_test_names branch June 13, 2023 12:28
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants