Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA doc: import torch before it is used #24228

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Conversation

ByronHsu
Copy link
Contributor

@ByronHsu ByronHsu commented Jun 13, 2023

What does this PR do?

import torch before it is used in qa doc. Otherwise, it complains import error.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 13, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I think you just need to run make style to get the tests to pass. Also pinging @amyeroberts for a final review!

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ByronHsu Thanks for you contribution and improving our docs!

Just a small nit from me. As @stevhliu mentions, you'll need to run make fixup locally at the top level of the repo and push any changes to resolve the failing quality checks. Once done, we're good to merge :)

docs/source/en/tasks/question_answering.mdx Outdated Show resolved Hide resolved
Signed-off-by: byhsu <byhsu@linkedin.com>
@ByronHsu
Copy link
Contributor Author

@amyeroberts @stevhliu mind checking again? thanks!

@amyeroberts
Copy link
Collaborator

@ByronHsu Thanks again for fixing! All looks good 👍

@amyeroberts amyeroberts merged commit 91b62f5 into huggingface:main Jun 14, 2023
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
* import torch before it is used

* style

Signed-off-by: byhsu <byhsu@linkedin.com>

---------

Signed-off-by: byhsu <byhsu@linkedin.com>
Co-authored-by: byhsu <byhsu@linkedin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants