update FSDP save and load logic #24249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
muellerzr
reviewed
Jun 13, 2023
Comment on lines
+2107
to
+2108
| load_fsdp_model( | ||
| self.accelerator.state.fsdp_plugin, self.accelerator, model, self.state.best_model_checkpoint |
There was a problem hiding this comment.
This will require folks use yet another higher version of Accelerate, else they'll get a load_fsdp_model not found if they pin Accelerate but not Transformers. When 0.21.0 (of accelerate) is out we should either pin to it as the new minimum, or have an explicit error/check in here so it's not a confusing error for folks due to this naming change.
I know fsdp is considered experimental to a degree, so trusting best judgement on if action is needed/what action to take :)
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* update fsdp save and load logic * fix * see if this resolves the failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?