Add torch >=1.12 requirement for Tapas
#24251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
ydshieh
commented
Jun 13, 2023
Comment on lines
536
to
539
| @unittest.skipIf( | ||
| not is_torch_greater_or_equal_than_1_12, | ||
| reason="`GPTBigCode` checkpoints use `PytorchGELUTanh` which requires `torch>=1.12.0`." | ||
| ) |
There was a problem hiding this comment.
@amyeroberts Just put this one to this PR to not opening a new PR. Sorry for doing this after PR being reviewed.
There was a problem hiding this comment.
No worries, thanks for pinging me on the comment to highlight :)
There was a problem hiding this comment.
Approval still stands :)
…/transformers into fix_tapas_in_past_ci
This was referenced Jun 14, 2023
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* fix * fix * fix * Update src/transformers/models/tapas/modeling_tapas.py Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com> Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tapas files are changed in #20149 to use torch's
scatter. The torch tensor's methodscatter_reduceaccept the argumentsrconly for torch >= 1.12.This PR add some warnings/requirements in tapas modeling/test files to avoid test failures in past CI with torch <= 1.11.
(one previous similar PR is #19851)