Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepspeed init during eval fix #24298

Merged
merged 2 commits into from
Jun 15, 2023
Merged

deepspeed init during eval fix #24298

merged 2 commits into from
Jun 15, 2023

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. Fixes Error during evaluation using deepspeed zero stage 2 #24294 as DS Z2 and Z1 stages don't modify the model and the check was exhibiting wrong behaviour.

@pacman100 pacman100 requested review from muellerzr and sgugger June 15, 2023 11:41
sgugger
sgugger reviewed Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

src/transformers/trainer.py Outdated Show resolved Hide resolved
src/transformers/trainer.py Outdated Show resolved Hide resolved
@pacman100 @sgugger
commit suggestions
06dab8e 
Co-Authored-By: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 15, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

muellerzr
muellerzr approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pacman100 pacman100 merged commit 01b5577 into main Jun 15, 2023
@pacman100 pacman100 deleted the smangrul/ds-eval-fix branch June 15, 2023 13:17
@GiulioGiorcelli
Copy link

Thanks for working on this. I'm currently running into the same issue with V 4.30.2. Any idea when the the new V with this fix will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@muellerzr muellerzr muellerzr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error during evaluation using deepspeed zero stage 2
5 participants
@pacman100 @HuggingFaceDocBuilderDev @GiulioGiorcelli @muellerzr @sgugger