[SwitchTransformers] Fix return values
#24300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurZucker
commented
Jun 15, 2023
Comment on lines
-1690
to
-1693
| encoder_router_logits, encoder_expert_indexes = self._unpack_router_logits( | ||
| encoder_outputs.router_probs |
There was a problem hiding this comment.
encoder_outputs.router_probs cannot be accessed if return_dict = False
ArthurZucker
commented
Jun 15, 2023
Comment on lines
-1721
to
-1727
| *decoder_outputs[1:], | ||
| *encoder_outputs, | ||
| ) | ||
| else: | ||
| output += (*decoder_outputs[1:], *encoder_outputs) |
There was a problem hiding this comment.
just reduce used lines
ArthurZucker
commented
Jun 15, 2023
| @@ -1736,18 +1723,18 @@ def forward( | |||
| decoder_hidden_states=decoder_outputs.hidden_states, | |||
| decoder_attentions=decoder_outputs.attentions, | |||
| cross_attentions=decoder_outputs.cross_attentions, | |||
| decoder_router_logits=decoder_outputs.router_probs, | |||
There was a problem hiding this comment.
make order of return consistent with tuples
|
The documentation is not available anymore as the PR was closed or merged. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The previous version of the code would always return
Nonevalues for the router losses, since theif output_router_probswas wrapper aroundif labels is not None. But router logits can still be computed wthout labels.Also returns tensors instead of None, this follows our usual API, and is less prone to errors.