-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wav2Vec2 - MMS] Correct directly loading adapters weights #24335
Merged
+193
−43
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7c00aed
Correct direct lang loading
patrickvonplaten 32a7678
correct more
patrickvonplaten 89fbb1a
revert black
patrickvonplaten 4b480ff
Use tie weights instead=
patrickvonplaten 7aadff8
add tests
patrickvonplaten 89e8baf
add tests
patrickvonplaten 05bfa13
make style
patrickvonplaten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd raise an exception here if it's called, otherwise it fails silently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah not 100% sure about the design here, but it seems much more in line with:
transformers/src/transformers/modeling_utils.py
Line 1257 in c5454eb
and
transformers/src/transformers/modeling_utils.py
Line 1242 in c5454eb
Think something like
if hasattr(self, "load_adaptive_weights")
is also not great.Also it is a bit questionable whether
load_adaptive_weights
is general enough to warrant to be inmodeling_utils.py
, but there is no other way really for the functionalityfrom_pretrained(..., target_lang="...")
@LysandreJik @sgugger wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I would override the
_tie_encoder_decoder_weights
method in Wav2Vec2 only and not add those changes in modeling_utils. If things change and we get lots of models with adapaters, we can revisit the decision and do something like this, but I'd wait for it to be necessary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's pretty hacky, but yeah ok for me. Will add a big comment that we do this to not introduce a new API