Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llama] Fix comments in weights converter #24436

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

weimingzha0
Copy link
Contributor

@weimingzha0 weimingzha0 commented Jun 22, 2023

Explain the reason to clone tensor

The original comment doesn't explain much about why we need to do clone.

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker @younesbelkada @sgugger

Explain the reason to clone tensor
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying!

@sgugger sgugger merged commit feb8352 into huggingface:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants