Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poor past ci #24485

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Fix poor past ci #24485

merged 2 commits into from
Jun 27, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jun 26, 2023

What does this PR do?

Screenshot 2023-06-26 102340

πŸ˜΅β€πŸ’« Let's be a bit nice to torch 1.11 and 1.10 πŸ™ .

(just a type issue: (line 641) RuntimeError: expected scalar type float but found double introduced in #24334)

@ydshieh ydshieh requested a review from gante June 26, 2023 08:26
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 26, 2023

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh requested a review from sgugger June 26, 2023 12:25
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it πŸ™

@ydshieh ydshieh merged commit 4abd3ee into main Jun 27, 2023
@ydshieh ydshieh deleted the fix_poor_ci branch June 27, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants