Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo #24559

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Fix Typo #24559

merged 1 commit into from
Jun 29, 2023

Conversation

tony9402
Copy link
Contributor

What does this PR do?

Fixed wrong annotation

  • (seq_len, BS, model_dim) -> (BS, seq_len, model_dim) -> (BS, seq_len, model_dim) -> (seq_len, BS, model_dim)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?

@sgugger
Copy link
Collaborator

sgugger commented Jun 28, 2023

Can you check if this is correct @ArthurZucker ?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 28, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as their is a similar comment afterwards, which puts it back to transformesr format:

# Convert to standard output format: (seq_len, BS, model_dim) -> (BS, seq_len, model_dim)

@sgugger sgugger merged commit 63cc30e into huggingface:main Jun 29, 2023
@tony9402 tony9402 deleted the fix-annotation-fsmt branch June 29, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants