Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip failing ZeroShotAudioClassificationPipelineTests::test_small_model_pt for now #24867

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jul 17, 2023

What does this PR do?

Skip failing ZeroShotAudioClassificationPipelineTests::test_small_model_pt for now.

see failing job

likely a datasets issue

@ydshieh ydshieh requested a review from sgugger July 17, 2023 19:29
@@ -27,6 +27,8 @@ class ZeroShotAudioClassificationPipelineTests(unittest.TestCase):
# and only CLAP would be there for now.
# model_mapping = {CLAPConfig: CLAPModel}

# TODO: fix me (ydshieh)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, probably @lhoestq too

Copy link
Member

@lhoestq lhoestq Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue comes from the CI using datasets @ git+https://github.com/huggingface/datasets@269fcd31a2e759c65ffd5952ecef13e6a0d92574 instead of the latest release of datasets (see "Show installed libraries and their versions" section in CircleCI)

This must be related to the CI runs I did on a dedicated branch to test transformers against datasets@main (looks like a pip site-packages cache issue)

This issue is also bothering me because now every time I test against datasets@main I end up with an outdated version of datasets@main (not the latest commit)

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 17, 2023

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger merged commit 870dfc1 into main Jul 17, 2023
4 checks passed
@sgugger sgugger deleted the skip_one_pip_test branch July 17, 2023 19:51
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
…del_pt` for now (huggingface#24867)

fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants