[split_special_tokens] Add support for split_special_tokens argument to encode
#25081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurZucker
changed the title
split_special_tokens] Add support for split_special_tokens argument to encodesplit_special_tokens] Add support for split_special_tokens argument to encode
1 task
ArthurZucker
commented
Jul 26, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
…to encode_special_token
ArthurZucker
commented
Aug 1, 2023
…to encode_special_token
…to encode_special_token
…to encode_special_token
ArthurZucker
changed the title
split_special_tokens] Add support for split_special_tokens argument to encodesplit_special_tokens] Add support for split_special_tokens argument to encode
ArthurZucker
commented
Aug 17, 2023
4 tasks
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
…ent to encode (huggingface#25081) * draft changes * update and add tests * styling for no * move test * path to usable model * update test * small update * update bertbased tokenizers * don'tuse kwargs for _tokenize * don'tuse kwargs for _tokenize * fix copies * update * update test for special tokenizers * fixup * skip two tests * remove pdb breakpiont() * wowo * rewrite custom tests * nits * revert chang in target keys * fix markup lm * update documentation of the argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Argument name is totally debatable. Will also require a pull request in
tokenizers.The goal is to be able to simply activate and de-activate the special token splitting. Feature was asked in #22490, and is required for some production type cases, where users pass inputs and we don't want them to be able to hack them