Set can_generate for SpeechT5ForTextToSpeech #25493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Aug 14, 2023
sanchit-gandhi
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Thanks - this is consistent with the rest of the library for developing the TTS pipeline in #24952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following the discussion on checking whether the generate or forward method will be used in the TTS pipeline, it makes sense to set
can_generate=TrueforSpeechT5ForTextToSpeech, so that it's easier to check if it can generate.Before submitting
Who can review?
Hey @sanchit-gandhi and @sgugger , what do you think of this??
Thanks!