Add ViTDet #25524
Merged
Add ViTDet #25524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
amyeroberts
approved these changes
Aug 16, 2023
|
@amyeroberts thanks for your review, I've addressed all the comments |
amyeroberts
reviewed
Aug 22, 2023
There was a problem hiding this comment.
Reminder to resolve this. Once that's done we can merge in the PR
There was a problem hiding this comment.
cc @ydshieh who knows the fix for this
There was a problem hiding this comment.
If you discard the change in this file of this PR, rebase on main, adding back ViTDet entry to this file and run the style, it will be fine.
A fix #25661 is merged into main.
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
* First draft * Fix READMEs * Update return_dict * Add more tests * Fix docstrings * Address comments * Address more comments * Address more comments * Address more comments, fix test * Fix test
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
* First draft * Fix READMEs * Update return_dict * Add more tests * Fix docstrings * Address comments * Address more comments * Address more comments * Address more comments, fix test * Fix test
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
* First draft * Fix READMEs * Update return_dict * Add more tests * Fix docstrings * Address comments * Address more comments * Address more comments * Address more comments, fix test * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds part 1 of #25051, namely the ViTDet backbone, introduced in Exploring Plain Vision Transformer Backbones for Object Detection.
Note that this PR only adds the backbone, hence there are no compatible checkpoints with the backbone-only. Those can only be added once either VitMatte or Mask R-CNN are added, both of which use VitDet as backbone.