Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[idefics] small fixes #25764

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[idefics] small fixes #25764

merged 1 commit into from
Aug 25, 2023

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Aug 25, 2023 •
edited
Loading

  • fix the example doc - where there was a wrong copy-n-paste model class used
  • remove IdeficsGatedCrossAttentionLayer from init imports as this is not really needed

thank you, @ydshieh for noticing these

@stas00 stas00 requested a review from ydshieh August 25, 2023 17:41
@stas00 stas00 marked this pull request as ready for review August 25, 2023 17:42
ydshieh
ydshieh approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stas00 stas00 merged commit 960807f into main Aug 25, 2023
@stas00 stas00 deleted the idefics-fixes branch August 25, 2023 17:59
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

LysandreJik pushed a commit that referenced this pull request Aug 28, 2023
@stas00 @LysandreJik
[idefics] small fixes (#25764)
13aef13
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
@stas00 @parambharat
[idefics] small fixes (huggingface#25764)
c6ff584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydshieh ydshieh ydshieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stas00 @HuggingFaceDocBuilderDev @ydshieh