Generate: models with custom generate()
return True
in can_generate()
#25838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See discussion in #25532
This PR updates
GenerationMixin.can_generate()
to also returnTrue
when a model has a customgenerate()
-- which means that the model is allowed to callgenerate()
. While at it, removes a few overloads, as they are redundant with the change in the PR ✂️Additional context: ALL models have a
generate()
function defined, as the mixin is added to all models. This function is a helper to detect when the model class is compatible withgenerate()
or not.Double-checking with code:
After this PR, this prints
True
in all cases except the last one, as expected.