Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLaMA resources #25859

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Add LLaMA resources #25859

merged 2 commits into from
Sep 5, 2023

Conversation

eenzeenee
Copy link
Contributor

@eenzeenee eenzeenee commented Aug 30, 2023

What does this PR do?

Adds resources of LLaMA according to this issue

Part of #20555

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu, @jungnerd, @wonhyeongseo may you please review this PR?

@jungnerd
Copy link
Contributor

LGTM! Please change this PR to Open.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for collecting and adding these! Just a minor few things to fix :)

docs/source/en/model_doc/llama.md Outdated Show resolved Hide resolved
docs/source/en/model_doc/llama.md Outdated Show resolved Hide resolved
docs/source/en/model_doc/llama.md Outdated Show resolved Hide resolved
docs/source/en/model_doc/llama.md Outdated Show resolved Hide resolved
@wonhyeongseo
Copy link
Contributor

wonhyeongseo commented Aug 31, 2023

Awesome job, @eenzeenee! 👏

For your final OSSCA report, consider these points:

  • 💡 Share your insights on potential enhancements for the resource.
  • 🚀 Reflect on the major challenge faced during this PR and your strategies to overcome it.
  • 🌱 Tell us about your upcoming adventures in the world of open source!

Keep up the fantastic work! 🎉

@jungnerd
Copy link
Contributor

One question, @stevhliu
Since Alpaca's backbone is LLaMA, can we add the resources of Alpaca in this doc?

docs/source/en/model_doc/llama.md Outdated Show resolved Hide resolved
@stevhliu
Copy link
Member

Since Alpaca's backbone is LLaMA, can we add the resources of Alpaca in this doc?

I think there are also several other variants of fine-tuned LLaMAs besides Alpaca, so for now, it may be better to just keep the focus on LLaMA.

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
@eenzeenee eenzeenee marked this pull request as ready for review September 3, 2023 02:26
@wonhyeongseo
Copy link
Contributor

wonhyeongseo commented Sep 5, 2023

Hello @stevhliu, may you please review this PR? Thank you! 😊

@stevhliu stevhliu merged commit 6206f59 into huggingface:main Sep 5, 2023
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* docs: feat: model resources for llama

* fix: resolve suggestion

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* docs: feat: model resources for llama

* fix: resolve suggestion

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
* docs: feat: model resources for llama

* fix: resolve suggestion

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants