Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix example failing doctest in generation_strategies.md #25874

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

gante
Copy link
Member

@gante gante commented Aug 30, 2023

What does this PR do?

The output was outdated, for some reason :)

@gante gante requested a review from ydshieh August 30, 2023 15:01
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. As we never run this one before, so works for me to change!

@gante
Copy link
Member Author

gante commented Aug 30, 2023

There was actually a bug in this decoding strategy that was fixes in v4.32, which may explain the output difference :)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 30, 2023

The documentation is not available anymore as the PR was closed or merged.

@gante gante merged commit 459bc67 into huggingface:main Aug 30, 2023
@gante gante deleted the fix_doctest_generation_strategies branch August 30, 2023 15:23
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants