Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated llama2.md to Korean #26047

Merged
merged 8 commits into from
Sep 12, 2023

Conversation

mjk0618
Copy link
Contributor

@mjk0618 mjk0618 commented Sep 8, 2023

What does this PR do?

Translated the llama2.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

May you please review this PR? @sgugger, @ArthurZucker, @eunseojo

Copy link
Contributor

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다! 😆
일부 리뷰를 해봤습니다. 검토 부탁드려요!

docs/source/ko/model_doc/llama2.md Outdated Show resolved Hide resolved
docs/source/ko/model_doc/llama2.md Outdated Show resolved Hide resolved
docs/source/ko/model_doc/llama2.md Outdated Show resolved Hide resolved
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
@mjk0618
Copy link
Contributor Author

mjk0618 commented Sep 8, 2023

좋은 번역 감사합니다! 😆 일부 리뷰를 해봤습니다. 검토 부탁드려요!

리뷰 감사합니다! 말씀해주신 부분 반영하여 커밋하였습니다.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@jungnerd
Copy link
Contributor

Uhhh hellooo? This PR should unexist.

Hi! I didn't understand what you meant, why shouldn't this PR exist?

@mjk0618 mjk0618 marked this pull request as ready for review September 11, 2023 13:08
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
@mjk0618
Copy link
Contributor Author

mjk0618 commented Sep 11, 2023

May you please review this PR? @sgugger, @ArthurZucker, @eunseojo

Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for translating this 😉

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for your translation! 🤗

@stevhliu stevhliu merged commit be9438e into huggingface:main Sep 12, 2023
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* docs: ko-llama2.md

* feat: chatGPT draft and manul edits

* feat: added inline TOC

* fix: inline TOC

* fix: resolve suggestions

Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>

* fix: resolve suggestion

Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>

* fix: resolve suggestion

Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>

---------

Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants