Fix eval accumulation when accelerate > 0.20.3
#26060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in: huggingface#25641 Eval accumulation will never happen with `accelerate > 0.20.3`, so this change ensures that `sync_gradients` is ignored if accelerate is > 0.20.3
4 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
amyeroberts
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Thanks for this fix!
Looks OK to me cc @muellerzr for a second opinion before merging
|
@muellerzr any thoughts :) |
muellerzr
approved these changes
Sep 13, 2023
|
Thanks! @amyeroberts @muellerzr is there any way to track when this fix will get added to a release? |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
As mentioned in: huggingface#25641 Eval accumulation will never happen with `accelerate > 0.20.3`, so this change ensures that `sync_gradients` is ignored if accelerate is > 0.20.3
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
As mentioned in: huggingface#25641 Eval accumulation will never happen with `accelerate > 0.20.3`, so this change ensures that `sync_gradients` is ignored if accelerate is > 0.20.3
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
As mentioned in: huggingface#25641 Eval accumulation will never happen with `accelerate > 0.20.3`, so this change ensures that `sync_gradients` is ignored if accelerate is > 0.20.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in: #25641
Eval accumulation will never happen with
accelerate > 0.20.3, so this change ensures thatsync_gradientsis ignored if accelerate is > 0.20.3What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.