chore: correct update_step and correct gradient_accumulation_steps #26068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyeroberts
approved these changes
Sep 12, 2023
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
amyeroberts
changed the title
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As discussed in issue #25691, it seems that the update step is incorrect. I have made corrections to all the files to ensure synchronization. However, during my edits, I noticed that there were multiple instances of incorrect variable name
args.gradient_accumulation_stepsso I have rectified these issues as well.I would like cc @ArthurZucker to review my code.