refactor: change default block_size in block size > max position embeddings #26069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your helpful information. |
|
No worries @pphuc25! Would you like to open a PR to set the block size to the minimum of |
|
That's the cool idea, I will do it, thank you @sanchit-gandhi. |
pphuc25
changed the title
sanchit-gandhi
approved these changes
Sep 18, 2023
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
ArthurZucker
approved these changes
Sep 18, 2023
MKhalusova
pushed a commit
to MKhalusova/transformers
that referenced
this pull request
Sep 19, 2023
…ddings (huggingface#26069) * refactor: change default block_size when not initialize * reformat: add the min of block size
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
…ddings (huggingface#26069) * refactor: change default block_size when not initialize * reformat: add the min of block size
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
…ddings (huggingface#26069) * refactor: change default block_size when not initialize * reformat: add the min of block size
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
…ddings (huggingface#26069) * refactor: change default block_size when not initialize * reformat: add the min of block size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In the original code, this appears to function correctly when the default block_size is set to 1024. However, I believe that this setting might potentially hinder the training performance. Therefore, I have adjusted the default to be max_position_embeddings when it doesn't match case.
I would like to cc @sanchit-gandhi to review my PR, thank you so much