Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change mention of decoder_input_ids to input_ids and same with decode_inputs_embeds #26406

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

tmabraham
Copy link
Contributor

The arguments to Llama2 is input_ids and inputs_embeds but yet in several places it is mentioned as decoder_input_ids and decoder_inputs_embeds including in some error messages. This PR fixes that.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

@LysandreJik
Copy link
Member

Could you just run the code quality tool to ensure that the code quality passes? You can install them with the following, from the root of your clone:

pip install -e ".[quality]"

And then run them with:

make fixup

@tmabraham
Copy link
Contributor Author

tmabraham commented Sep 26, 2023

Hmm looks like something is wrong? Not sure if I am doing something wrong...

(base) tmabraham@DESKTOP-TPBRMQJ:/mnt/c/Users/tmabraham/Documents/GitHub/transformers$ make fixup
make: Warning: File 'Makefile' has modification time 70901 s in the future
No library .py files were modified
python utils/custom_init_isort.py
python utils/style_doc.py src/transformers docs/source --max_len 119
running deps_table_update
updating src/transformers/dependency_versions_table.py
python utils/class_mapping_update.py
python utils/check_copies.py
Traceback (most recent call last):
  File "/mnt/c/Users/tmabraham/Documents/GitHub/transformers/utils/check_copies.py", line 353, in <module>
    check_copies(args.fix_and_overwrite)
  File "/mnt/c/Users/tmabraham/Documents/GitHub/transformers/utils/check_copies.py", line 186, in check_copies
    new_diffs = is_copy_consistent(filename, overwrite)
  File "/mnt/c/Users/tmabraham/Documents/GitHub/transformers/utils/check_copies.py", line 164, in is_copy_consistent
    theoretical_code = blackify(lines[start_index - 1] + theoretical_code)
  File "/mnt/c/Users/tmabraham/Documents/GitHub/transformers/utils/check_copies.py", line 104, in blackify
    result = black.format_str(code, mode=black.FileMode([black.TargetVersion.PY35], line_length=119))
  File "<string>", line 3, in __init__
TypeError: set object expected; got list
make: *** [Makefile:38: extra_quality_checks] Error 1

@LysandreJik
Copy link
Member

Hmm indeed this seems like a weird error! I pushed a fix directly to your branch, I'll merge this PR as soon as it's green.

Thanks for your PR!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@LysandreJik LysandreJik merged commit 098c3f4 into huggingface:main Sep 28, 2023
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
…_inputs_embeds (huggingface#26406)

* change mention of decoder_input_ids to input_ids and same with decoder_input_embeds

* Style

---------

Co-authored-by: Lysandre <lysandre@huggingface.co>
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
…_inputs_embeds (huggingface#26406)

* change mention of decoder_input_ids to input_ids and same with decoder_input_embeds

* Style

---------

Co-authored-by: Lysandre <lysandre@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants