-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change mention of decoder_input_ids to input_ids and same with decode_inputs_embeds #26406
change mention of decoder_input_ids to input_ids and same with decode_inputs_embeds #26406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR!
Could you just run the code quality tool to ensure that the code quality passes? You can install them with the following, from the root of your clone:
And then run them with:
|
Hmm looks like something is wrong? Not sure if I am doing something wrong...
|
Hmm indeed this seems like a weird error! I pushed a fix directly to your branch, I'll merge this PR as soon as it's green. Thanks for your PR! |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
…_inputs_embeds (huggingface#26406) * change mention of decoder_input_ids to input_ids and same with decoder_input_embeds * Style --------- Co-authored-by: Lysandre <lysandre@huggingface.co>
…_inputs_embeds (huggingface#26406) * change mention of decoder_input_ids to input_ids and same with decoder_input_embeds * Style --------- Co-authored-by: Lysandre <lysandre@huggingface.co>
The arguments to Llama2 is
input_ids
andinputs_embeds
but yet in several places it is mentioned asdecoder_input_ids
anddecoder_inputs_embeds
including in some error messages. This PR fixes that.