Add torch RMSProp optimizer
#26425
Merged
Add torch RMSProp optimizer
#26425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesbelkada
approved these changes
Sep 26, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Good to me as well, just wondering why we did not have it before? cc @pacman100
|
Thanks, I can't merge it as I don't have write access, so @ArthurZucker or @younesbelkada can do so! |
ydshieh
added a commit
that referenced
this pull request
Oct 30, 2023
ydshieh
added a commit
that referenced
this pull request
Oct 30, 2023
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
add rmsprop
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
add rmsprop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add torch
RMSPropfor easy use in TRL library, particularly to match the default use case of Direct Preference Optimization.Script is here.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@younesbelkada and I discussed this.