Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin Keras for now #26904

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Pin Keras for now #26904

merged 4 commits into from
Oct 19, 2023

Conversation

Rocketknight1
Copy link
Member

With Keras 3 on the horizon, let's pin Keras versions to ensure things don't break until we can transition properly

ydshieh
ydshieh approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@ydshieh
Copy link
Collaborator

ydshieh commented Oct 19, 2023

There are a few pip install -U --upgrade-strategy eager tensorflow_probability in .circleci/create_circleci_config.py. I guess we will need to pin them too. But not sure if we already know the corresponding version.

@Rocketknight1
Copy link
Member Author

@ydshieh yeah, tensorflow_probability versions don't seem to be linked to TF versions. It also doesn't seem to use Keras much - hopefully we can leave it unpinned for now, and do a PR to pin it if it becomes a problem later!

@Rocketknight1 Rocketknight1 merged commit cbd278f into main Oct 19, 2023
22 checks passed
@Rocketknight1 Rocketknight1 deleted the keras_pin branch October 19, 2023 13:39
@ydshieh
Copy link
Collaborator

ydshieh commented Oct 19, 2023

(remark: I did see some failing before when tensorflow_probability complained about the TF version is not compatible with it - or vice versa 😅 )

staghado pushed a commit to staghado/transformers that referenced this pull request Oct 24, 2023
@Rocketknight1 @staghado
Pin Keras for now (huggingface#26904)
abcfe35 
* Pin Keras for now out of paranoia

* Add the keras pin to _tests_requirements.txt too

* Make sure the Keras version matches the TF one

* make fixup
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
@Rocketknight1 @EduardoPach
Pin Keras for now (huggingface#26904)
d0fa51b 
* Pin Keras for now out of paranoia

* Add the keras pin to _tests_requirements.txt too

* Make sure the Keras version matches the TF one

* make fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

@ydshieh ydshieh ydshieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rocketknight1 @ydshieh @ArthurZucker