Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-ZH] Translate multilingual into Chinese #26935

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

yyLeaves
Copy link
Contributor

What does this PR do?

Add zh (Chinese) translation for multilingual.md. #20095

Who can review?

Documentation: @stevhliu
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🤗


语言嵌入被表示一个张量,其形状与传递给模型的 `input_ids` 相同。这些张量中的值取决于所使用的语言,并由分词器的 `lang2id` 和 `id2lang` 属性识别。

在此示例中,加载 `xlm-clm-enfr-1024` 检查点(因果语言建模,英语-法语):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
在此示例中,加载 `xlm-clm-enfr-1024` 检查点(因果语言建模,英语-法语
在此示例中,加载 `xlm-clm-enfr-1024` 检查点(因果语言建模,英语-法语)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, change the right bracket alone to English style makes it unmatch with the left bracket.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, so we should keep the space between the ) and :? For example, on line 29 there is no space between the : and the last character.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, so we should keep the space between the ) and :? For example, on line 29 there is no space between the : and the last character.

I don't think there is extra space between and . The problem is that they are Chinese punctuations and look like they take one extra space but actually there isn't a space in between, as in line 41.

  • English punctuation: ):
  • Chinese punctuation: ):

Some subtitle group such as 人人字幕组 don't like it either, so they replace some punctuations in Chinese subtitles into English style to make it look better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification! In that case, we're good to merge :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevhliu Thanks!

@stevhliu stevhliu merged commit 19ae050 into huggingface:main Oct 23, 2023
8 checks passed
staghado pushed a commit to staghado/transformers that referenced this pull request Oct 24, 2023
translate multilingual into Chinese

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
translate multilingual into Chinese

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants