Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate: update basic llm tutorial #26937

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Generate: update basic llm tutorial #26937

merged 1 commit into from
Oct 19, 2023

Conversation

gante
Copy link
Member

@gante gante commented Oct 19, 2023 •
edited
Loading

What does this PR do?

This PR updates the basic LLM tutorial in the following aspects:

  1. Adds a short section right at the top on how to do batched generation. This was made to address How to perform batch inference?  #26061 (and other similar issues in the past)
  2. Updates the model used in the examples from OpenLlama (permissive licenses, but deprecated) to Mistral (latest 7B model with top performance and permissive licenses)
  3. Adds prompting to the list of common issues (was a TODO)
  4. Adds pointers to recent guides about prompting and performance

Fixes #26061

@gante gante mentioned this pull request Oct 19, 2023
Closed
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 19, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

ArthurZucker
ArthurZucker approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks for the cleanup

@gante gante merged commit ae4fb84 into huggingface:main Oct 19, 2023
8 checks passed
@gante gante deleted the batched_basic_docs branch October 19, 2023 15:53
staghado pushed a commit to staghado/transformers that referenced this pull request Oct 24, 2023
@gante @staghado
Generate: update basic llm tutorial (huggingface#26937)
4439b29
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
@gante @EduardoPach
Generate: update basic llm tutorial (huggingface#26937)
7023542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to perform batch inference?
3 participants
@gante @HuggingFaceDocBuilderDev @ArthurZucker