Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuyu: improve image processing #27007

Merged
merged 11 commits into from
Nov 2, 2023
Merged

Fuyu: improve image processing #27007

merged 11 commits into from
Nov 2, 2023

Commits on Oct 18, 2023

  1. Fix Fuyu image scaling bug

    It could produce negative padding and hence inference errors for certain
    image sizes.
    pcuenca committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    36f52d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Merge remote-tracking branch 'origin/fuyu-scaling-fix' into fuyu_foll…

    …ow_up_image_processing
    molbap committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    c710fa9 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. initial rework commit

    molbap committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    1166ca9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    78830e2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dd6e2c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. make args explicit

    molbap committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    4d85112 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Fuyu processing update (#27133)

    * Add file headers
    
    * Add file headers
    
    * First pass - preprocess method with standard args
    
    * First pass image processor rework
    
    * Small tweaks
    
    * More args and docstrings
    
    * Tidying iterating over batch
    
    * Tidying up
    
    * Modify to have quick tests (for now)
    
    * Fix up
    
    * BatchFeature
    
    * Passing tests
    
    * Add tests for processor
    
    * Sense check when patchifying
    
    * Add some tests
    
    * FuyuBatchFeature
    
    * Post-process box coordinates
    
    * Update to `size` in processor
    
    * Remove unused and duplicate constants
    
    * Store unpadded dims after resize
    
    * Fix up
    
    * Return FuyuBatchFeature
    
    * Get unpadded sizes after resize
    
    * Update exception
    
    * Fix return
    
    * Convert input `<box>` coordinates to model format.
    
    * Post-process point coords, support multiple boxes/points in a single
    sequence
    
    * Replace constants
    
    * Update src/transformers/models/fuyu/image_processing_fuyu.py
    
    Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
    
    * Preprocess List[List[image]]
    
    * Update src/transformers/models/fuyu/image_processing_fuyu.py
    
    Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
    
    * Update to Amy's latest state.
    
    * post-processing returns a list of tensors
    
    * Fix error when target_sizes is None
    
    Co-authored-by: Pablo Montalvo <pablo.montalvo.leroux@gmail.com>
    
    * Update src/transformers/models/fuyu/image_processing_fuyu.py
    
    Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
    
    * Update src/transformers/models/fuyu/image_processing_fuyu.py
    
    Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
    
    * Update src/transformers/models/fuyu/image_processing_fuyu.py
    
    Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
    
    * Update src/transformers/models/fuyu/image_processing_fuyu.py
    
    Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
    
    * Review comments
    
    * Update src/transformers/models/fuyu/image_processing_fuyu.py
    
    Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
    
    * Fix up
    
    * Fix up
    
    ---------
    
    Co-authored-by: Ubuntu <ubuntu@ip-172-31-72-126.ec2.internal>
    Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
    Co-authored-by: Pablo Montalvo <pablo.montalvo.leroux@gmail.com>
    4 people committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    584f792 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Configuration menu
    Copy the full SHA
    060e545 View commit details
    Browse the repository at this point in the history
  2. Fix conflicts in fuyu_follow_up_image_processing (#27228)

    fixing conflicts and updating on main
    pcuenca committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    acce10b View commit details
    Browse the repository at this point in the history
  3. Revert "Fix conflicts in fuyu_follow_up_image_processing" (#27232)

    Revert "Fix conflicts in fuyu_follow_up_image_processing (#27228)"
    
    This reverts commit acce10b.
    molbap committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    665a565 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'fuyu_follow_up_image_processing' of github.com:huggingf…

    …ace/transformers into fuyu_follow_up_image_processing
    molbap committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    babe5f7 View commit details
    Browse the repository at this point in the history