Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit to inferior fsspec version #27010

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Limit to inferior fsspec version #27010

merged 1 commit into from
Oct 23, 2023

Conversation

LysandreJik
Copy link
Member

The newly released fsspec version breaks the implementation in transformers' CI, see the following error:

"/home/circleci/.pyenv/versions/3.8.12/lib/python3.8/site-packages/datasets/builder.py", line 1173, in as_dataset
    raise NotImplementedError(f"Loading a dataset cached in a {type(self._fs).__name__} is not supported.")
NotImplementedError: Loading a dataset cached in a LocalFileSystem is not supported.
/home/circleci/transformers/src/transformers/models/beit/modeling_beit.py:737: UnexpectedException

Additionally:
huggingface/datasets#6331 and huggingface/huggingface_hub#1773

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 23, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

ArthurZucker
ArthurZucker approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing the CIs back!

@LysandreJik LysandreJik merged commit 7003294 into main Oct 23, 2023
18 of 22 checks passed
@LysandreJik LysandreJik deleted the fix-failing-tests branch October 23, 2023 10:34
staghado pushed a commit to staghado/transformers that referenced this pull request Oct 24, 2023
@LysandreJik @staghado
Limit to inferior fsspec version (huggingface#27010)
34acb4c 
Pin fsspec
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
@LysandreJik @EduardoPach
Limit to inferior fsspec version (huggingface#27010)
3bbef36 
Pin fsspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LysandreJik @HuggingFaceDocBuilderDev @ArthurZucker