Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashlib specification #27038

Closed
wants to merge 5 commits into from

Conversation

DueViktor
Copy link

What does this PR do?

The following PR address the issue raised in #27034.

Fixes # (issue)
Close #27034

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DueViktor
Copy link
Author

@ArthurZucker, perhaps you can review this?

@ArthurZucker
Copy link
Collaborator

ArthurZucker commented Oct 26, 2023

Hey! As this might affect other HF repos we want to take our time and find a solution for all of them 🤗 gotta be aligned with other library maintainers! FYI @Wauplin

@DueViktor
Copy link
Author

Hey! As this might affect other HF repos we want to take our time and find a solution for all of them 🤗 gotta be aligned with other library maintainers! FYI @Wauplin

That's fair. In case you need some references, similar changes have been included in other repos:

@Wauplin
Copy link
Contributor

Wauplin commented Oct 27, 2023

Thanks a lot @DueViktor for raising the question 🙏 I opened a PR in huggingface_hub which is the underlying library common to the other HF-libraries (transformers, diffusers, datasets,.): huggingface/huggingface_hub#1782. My plan is to release that and then integrate with dependent libraries once adopted.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@Wauplin
Copy link
Contributor

Wauplin commented Nov 24, 2023

Closing this PR without merging. This has been handled in a separate PR (see #27034 for full context).

@Wauplin Wauplin closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hashlib usage is underspecified
3 participants