-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
device agnostic fsdp testing #27120
device agnostic fsdp testing #27120
Conversation
cc @ydshieh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me :-)
@statelesshz How these tests happen for multiple npu device? They pass or fail? |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
@ydshieh Only one test case failed due to missing communication operator,and I will upload the test log tomorrow :-) |
System info
test result
import torch
import torch_npu
# !! Further additional imports can be added here !!
# Specify the device name (eg. 'cuda', 'cpu', 'npu')
DEVICE_NAME = 'npu:0'
# Specify device-specific backends to dispatch to.
# If not specified, will fallback to 'default' in 'testing_utils.py`
MANUAL_SEED_FN = torch.npu.manual_seed_all
EMPTY_CACHE_FN = torch.npu.empty_cache
DEVICE_COUNT_FN = torch.npu.device_count do the following instructions:
The output is as follows
|
FYI #27120 (comment) 😄 @ydshieh |
Is this PR still under review? Please inform me if any further revisions are required :-) @ydshieh and @amyeroberts |
We don't expect all tests 100% run without problem on other devices. My question is just to see what is the current results. It doesn't seem bad running on NPU ! LGTM but waiting @amyeroberts to give her 👍 if everything is good to her. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for another great PR!
* make fsdp test cases device agnostic * make style
What does this PR do?
Part of #25654 (comment)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
cc @ydshieh and @ArthurZucker